Remove unnecessary, and incorrect, Java error message translation

[retronym]

Given:

class C {
    class D {}
    void test() {
        D.this.toString();
    }
}

Before:

⚡ sbt compile
[info] Loading settings from dirtymoney.sbt,gpg.sbt,idea.sbt ...
[info] Loading global plugins from /Users/jz/.sbt/1.0/plugins
[info] Loading project definition from /private/tmp/javac-diagnostic/project
[info] Set current project to javac-diagnostic (in build file:/private/tmp/javac-diagnostic/)
[info] Executing in batch mode. For better performance use sbt's shell
[info] Compiling 1 Java source to /private/tmp/javac-diagnostic/target/scala-2.12/classes ...
[error] /private/tmp/javac-diagnostic/src/main/java/example/Test.java:4:1:  C.D
[error]         D.this.toString();
[error] (Compile / compileIncremental) javac returned non-zero exit code
[error] Total time: 0 s, completed 05/04/2018 12:52:16 PM
/tmp/javac-diagnostic

After:

⚡ sbt -sbt-version 1.1.3-pre-98d08039e
Getting org.scala-sbt sbt 1.1.3-pre-98d08039e  (this may take some time)...
:: retrieving :: org.scala-sbt#boot-app
    confs: [default]
    77 artifacts copied, 0 already retrieved (27803kB/251ms)
...
[info] Set current project to javac-diagnostic (in build file:/private/tmp/javac-diagnostic/)
[info] sbt server started at local:///Users/jz/.sbt/1.0/server/3cc671e1c4b514e4d201/sock
sbt:javac-diagnostic> compile
[info] Compiling 1 Java source to /private/tmp/javac-diagnostic/target/scala-2.12/classes ...
[error] /private/tmp/javac-diagnostic/src/main/java/example/Test.java:4:1: not an enclosing class: C.D
[error]         D.this.toString();
[error] (Compile / compileIncremental) javac returned non-zero exit code
[error] Total time: 0 s, completed 05/04/2018 1:02:53 PM
sbt:javac-diagnostic>

Fixes #523

[dwijnand]

looks like something that could have a test for it.

or is there an impediment to a test for this case?

[dwijnand]

btw looking in sbt/sbt#1702 I can't find any more info about fixedDiagnosticMessage.

[retronym]

I wasn't sure how to structure the a (scripted?) test to make assertions about the javac output. I'm sure there is a way, but I'm trying to get out of my SBT fix 🐰 hole for the week, so was a bit lazy.

[retronym]

My best guess is that the code used to call toString (which does include the file/line number), but was changed to use getMessage before sbt/sbt#1702 landed.

[dwijnand]

so was a bit lazy

no worries, I'll try and follow this up with a test.