-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracking Issue: using viaIR in versions >= 0.8.7 #861
Labels
Comments
This was referenced Feb 10, 2024
Update: Patched in v0.8.10 (& a little more in 0.8.11)#870 is reporting some missing line coverage. The instrumentation disappears in two cases: uint24 quantity = _cancelOrdersSide(_orderIds[i], price, bidsAtPrice[tokenId][price], bids[tokenId]);
brushFromUs += quantity * price; // <--- not covered for (uint i = _index; i < _segments.length.sub(1); ++i) {
_segments[i] = _segments[i.inc()]; // <--- not covered
} Compiling with 0.8.24 Something to note is that the instrumentation is preserved if console.log statements are added, so there must be a way to make it sticky. |
cgewecke
changed the title
Using viaIR in versions >= 0.8.7
Tracking Issue: using viaIR in versions >= 0.8.7
Feb 28, 2024
Closing b/c this seems like it's resolved now. Will re-open if there are new reports of issues. |
This was referenced Jul 17, 2024
This was referenced Aug 2, 2024
This was referenced Aug 6, 2024
This was referenced Sep 19, 2024
This was referenced Sep 24, 2024
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Problems with
viaIR
resulting in 0% coverage should be resolved by v0.8.7. Release notes with advice about upgrading are hereThere is a working example of the patch in this E2E test PR against the 1inch/solidity-utils repo.
If you're still experiencing problems with this please report them here and
The text was updated successfully, but these errors were encountered: