Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add JDK 14 community build #984

Closed
SethTisue opened this issue Oct 3, 2019 · 8 comments
Closed

add JDK 14 community build #984

SethTisue opened this issue Oct 3, 2019 · 8 comments
Assignees
Labels

Comments

@SethTisue
Copy link
Member

SethTisue commented Oct 3, 2019

I'm not sure we really have the resources for this at present, and I think adding Graal is a higher priority.

Regardless, yes at some point we should replace the JDK 13 build with a JDK 14 one.

The JDK 13 ticket is #873, we should work through that one first.

Note that JDK 14 isn't LTS. (JDK 17 will be LTS.)

@SethTisue
Copy link
Member Author

according to https://openjdk.java.net/projects/jdk/14/ ,

2020/02/06 |   | Initial Release Candidate
2020/02/20 |   | Final Release Candidate
2020/03/17 |   | General Availability

@SethTisue SethTisue removed their assignment Oct 16, 2019
@SethTisue
Copy link
Member Author

SethTisue commented Oct 22, 2019

on MacOS, one way to get 14 is:

  1. brew cask install java-beta
  2. (if on Catalina) sudo xattr -dr com.apple.quarantine /Library/Java/JavaVirtualMachines/openjdk-14.jdk
  3. export JAVA_HOME=$(/usr/libexec/java_home -v 14)

@SethTisue
Copy link
Member Author

for now, just to make sure something isn't horribly broken build-wide, I did local runs of a subset of the build on MacOS using "OpenJDK Runtime Environment (build 14-ea+14-570)" and got similar results as we're seeing on JDK 13.

(on 2.12.x and 2.13.x I used ./narrow play-webgoat scala-pet-store as the subset, on 2.11.x ./narrow play-webgoat http4s)

@SethTisue SethTisue self-assigned this Jan 24, 2020
@SethTisue
Copy link
Member Author

14's release date is now just a couple months away, and I think we've learned everything we're going to learn from the 13 build, so now seems like a good time to swap in 14 for 13

sudo apt-get install adoptopenjdk-14-hotspot doesn't work yet, and 14 isn't available from https://adoptopenjdk.net/installation.html yet anyway

so installation steps are:

cd /usr/lib/jvm
sudo curl -O -L 'https://download.java.net/java/early_access/jdk14/33/GPL/openjdk-14-ea+33_linux-x64_bin.tar.gz'
sudo dtrx -n openjdk-14-ea+33_linux-x64_bin.tar.gz
sudo rm openjdk-14-ea+33_linux-x64_bin.tar.gz
sudo chmod -R go+rX openjdk-14-ea+33_linux-x64_bin
sudo ln -s openjdk-14-ea+33_linux-x64_bin java-14-openjdk-x64

I did this on all 3 behemoths

then in Jenkins I renamed the two jdk13 jobs (2.12.x and 2.13.x) to jdk14 and changed the jvmVersion to 14, and also ssh'ed in to the behemoths and deleted the jdk13 workspaces

then I triggered new runs and checked the logs to see if they're successfully selecting JDK 14, and they are. both jobs are running now:

@SethTisue
Copy link
Member Author

this is done

results are very similar to the JDK 13 results. I did a few more test runs, excluded a few tests, reported a new Akka failure upstream, marked a repo or two as expected-to-fail, little things like that

I may do some light followup work to see if we can shorten the expected-to-fail list

@SethTisue
Copy link
Member Author

https://openjdk.java.net/projects/jdk/14/ says that the "final release candidate" is coming Feb 20. I should upgrade the behemoths as soon as it's available. I'll check it on Feb 21

@SethTisue
Copy link
Member Author

final is out. ticket: #1109

@SethTisue
Copy link
Member Author

the action is moving to JDK 15 now: #1225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant