Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish sources of synthetic classes and types in -sources.jar artefacts #20073

Closed
unkarjedy opened this issue Apr 2, 2024 · 2 comments · Fixed by #20904
Closed

publish sources of synthetic classes and types in -sources.jar artefacts #20073

unkarjedy opened this issue Apr 2, 2024 · 2 comments · Fixed by #20904
Assignees
@Florian3k
Labels
area:doctool area:source-jars Issues tied to generating *-sources.jar artifacts. itype:enhancement
Milestone
3.5.1

Comments

@unkarjedy
Copy link
Contributor

unkarjedy commented Apr 2, 2024 •
edited
Loading

Similar to scala/bug#12958 but for Scala 3 synthetic classes.

Those classes are already published for docs (examples: AnyKind, Matchable)
It would be nice to publish in sources to be able to see their description in the IDE

Related:
https://youtrack.jetbrains.com/issue/SCL-22350
https://youtrack.jetbrains.com/issue/SCL-22167

Full list of classes

  • AnyKind
  • Matchable
  • &
  • |
@unkarjedy unkarjedy changed the title publish sources of synthetic classes in -sources.jar artefacts publish sources of synthetic classes and types in -sources.jar artefacts Apr 2, 2024
@unkarjedy unkarjedy mentioned this issue Apr 2, 2024
Closed
@unkarjedy
Copy link
Contributor Author

Related question.
Should Scala 3 repo duplicate ScalaDoc for Scala 2 synthetic classes?
Scala 3 repo: https://github.com/scala/scala3/blob/release-3.4.1/compiler/src/dotty/tools/dotc/core/Definitions.scala#L2446
Scala 2 repo: https://github.com/scala/scala/tree/2.13.x/src/library-aux/scala

@unkarjedy
Copy link
Contributor Author

unkarjedy commented Apr 3, 2024 •
edited
Loading

Also, it seems like ContextFunctionN classes could be published for Scala 3 in the same way it's done for ProductN, FunctionN and TupleN classes in Scala 2

@Gedochao Gedochao added the area:source-jars Issues tied to generating *-sources.jar artifacts. label May 10, 2024
@Florian3k Florian3k mentioned this issue Jul 1, 2024
Merged
@Kordyjan Kordyjan added this to the 3.5.1 milestone Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Florian3k Florian3k

Labels
area:doctool area:source-jars Issues tied to generating *-sources.jar artifacts. itype:enhancement
Projects
None yet
Milestone
3.5.1
Development

Successfully merging a pull request may close this issue.

Add sources of synthetic classes to sources jar Florian3k/scala3
4 participants
@unkarjedy @Kordyjan @Gedochao @Florian3k