Don't search for implicit conversions to NoType #19563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
Jan 29, 2024
|
Btw. as a side note to test it in Metals, you only need to do |
|
Glad it helped! |
|
I think this should go into LTS as well. |
odersky
added
the
backport:nominated
WojciechMazur
removed
the
backport:nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a good chance this will fix #19320. My problem is that without a lot of added boilerplate I cannot test it, since it's hard to have at the same time external dependencies and ad-hoc instrumentation in the compiler. But what I could observe from the minimized example, it searches for a conversion of
Concurrent[F[_]]toNoTypeand that must have caused the blowup.In any case, the change makes obvious sense, so let's add that and see whether it improves things.