Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[regression] Publish nightly releases and releases using Java 8 #19722

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

hamzaremmal
Copy link
Member

@hamzaremmal hamzaremmal commented Feb 17, 2024

Close #19721

[test_java8]

@hamzaremmal hamzaremmal self-assigned this Feb 17, 2024
@@ -723,6 +723,8 @@ jobs:
SONATYPE_USER: ${{ secrets.SONATYPE_USER_ORGSCALALANG }}

steps:
- name: Set JDK 8 as default
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't explicitly set the version, CI will use Java 21

- name: Set JDK 17 as default
run: echo "/usr/lib/jvm/java-17-openjdk-amd64/bin" >> $GITHUB_PATH
- name: Set JDK 8 as default
run: echo "/usr/lib/jvm/java-8-openjdk-amd64/bin" >> $GITHUB_PATH
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for making the build future-proof, we should add explicit -source/-release/-target flags to JDK to always emit JDK 8 bytecode and use only JDK API available in that version.
Same issue might be also present in normal releases

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this would have to be set in SBT, not in the CI configuration. The best we can do from the CI point of view is switch the default Java version.

@hamzaremmal
Copy link
Member Author

hamzaremmal commented Feb 17, 2024

CI failure is similar to #18344. Restarting the CI might fix it (See #19535)

@WojciechMazur WojciechMazur merged commit c3a1959 into scala:main Feb 19, 2024
19 checks passed
@hamzaremmal hamzaremmal deleted the i19721 branch February 19, 2024 13:47
@Kordyjan Kordyjan added this to the 3.4.2 milestone Mar 28, 2024
WojciechMazur pushed a commit that referenced this pull request Jul 1, 2024
WojciechMazur pushed a commit that referenced this pull request Jul 2, 2024
WojciechMazur added a commit that referenced this pull request Jul 2, 2024
…va 8" to LTS (#20925)

Backports #19722 to the LTS branch.

PR submitted by the release tooling.
[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nightly versions are published using Java 17
3 participants