Check deprecation of inline methods #19914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
fix-19913
branch
2 times, most recently
from
14b51ba to
0c7b0a4
Compare
hamzaremmal
approved these changes
Mar 19, 2024
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks. Fixes scala#19913
nicolasstucki
force-pushed
the
fix-19913
branch
from
0c7b0a4 to
f2ba6f4
Compare
WojciechMazur
added a commit
that referenced
this pull request
Jul 4, 2024
Backports #19914 to the LTS branch. PR submitted by the release tooling. [skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We must check these constraint just before inlining as later on there on the call might completely disappear. We do the same as we did for experimental definition checks.
Fixes #19913
Changes
CrossVersionChecks.checkRefthat checks both deprecation and experimental.InlinesandPostTyperto check the deprecation of inlined calls.checkDeprecatedtocheckDeprecatedRefcheckDeprecatedRefandskipWarningtoobject CrossVersionChecks