Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue 20901: etaCollapse context bound type #20910

Merged
merged 2 commits into from
Jul 1, 2024
Merged

fix issue 20901: etaCollapse context bound type #20910

merged 2 commits into from
Jul 1, 2024

Conversation

bishabosha
Copy link
Member

fixes #20901

@bishabosha bishabosha added the backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. label Jul 1, 2024
@bishabosha bishabosha requested review from odersky and Gedochao July 1, 2024 15:05
@WojciechMazur WojciechMazur added this to the 3.5.0 milestone Jul 1, 2024
odersky
odersky approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjrd sjrd enabled auto-merge July 1, 2024 17:30
@sjrd sjrd merged commit d68b645 into scala:main Jul 1, 2024
22 checks passed
@sjrd sjrd deleted the fix-context-bounds-simplify branch July 1, 2024 22:22
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" and removed backport:nominated If we agree to backport this PR, replace this tag with "backport:accepted", otherwise delete it. labels Jul 2, 2024
@WojciechMazur WojciechMazur mentioned this pull request Jul 2, 2024
Merged
WojciechMazur added a commit that referenced this pull request Jul 3, 2024
@WojciechMazur
Backport "fix issue 20901: etaCollapse context bound type" to 3.5.0 (#…
9ca1d0a 
…20956)

Backports #20910 to 3.5.0-RC3
hamzaremmal
hamzaremmal reviewed Jul 3, 2024
View reviewed changes
tests/pos/i20901/Foo.tastycheck
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this test is breaking the Scala 2 Library TASTy test in the latest nightly: https://github.com/scala/scala3/actions/runs/9771174027/job/26973528590

Copy link
Member Author

@bishabosha bishabosha Jul 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The failure is in the TASTy output test added in this PR, but the difference doesn't seem related to context bounds - tree 68 changed - the inferred result type

-68:         SHAREDtype 44
+68:         TYPEREF 17 [Nothing]
+70:           TERMREFpkg 2 [scala]

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we could possibly update the test to remove inference, or just stop the tasty checking

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or test with decompilation rather than printing tasty?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m sorting it out

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see #21001

@WojciechMazur WojciechMazur added backport:done This PR was successfully backported. and removed backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 3, 2024
@WojciechMazur WojciechMazur added backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" backport:done This PR was successfully backported. and removed backport:done This PR was successfully backported. backport:accepted This PR needs to be backported, once it's been backported replace this tag by "backport:done" labels Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamzaremmal hamzaremmal hamzaremmal left review comments

@odersky odersky odersky approved these changes

@Gedochao Gedochao Awaiting requested review from Gedochao

Assignees

@odersky odersky

Labels
backport:done This PR was successfully backported.
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.

Context bounds types are not simplified in TASTy
5 participants
@bishabosha @odersky @hamzaremmal @sjrd @WojciechMazur