Fix some memory leaks #2876
Merged
Fix some memory leaks #2876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After setting the `inst` field of a TypeVar, the owningState is no longer needed. Null it out in order to avoid a memory leak (TypeStates refer to constraints and error logs and error logs can refer to contexts via unforced diagnostic messages).
smarter
approved these changes
Jul 16, 2017
`owningState` of `TypeVar` was still a source of memory leaks even though we null it out when a TypeVar gets instantiated. The problem is that uninstantiated TypeVars can sit as parts of types in caches.
Message expressions usually capture contexts, which can cause space leaks if an error type is stored in a retained tree.
In LambdaLift, fields used only in the constructor of a class should not be marked free in the enclosing class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a series of commits to fix some memory leaks detected when using the IDE for some time.
My workflow is as follows:
we want to avoid hanging onto a Context beyond the run where it was created.