Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include scala extension in Azure Data Studio marketplace #67

Open
yualan opened this issue Oct 24, 2019 · 8 comments
Open

Include scala extension in Azure Data Studio marketplace #67

yualan opened this issue Oct 24, 2019 · 8 comments
Labels
ecosystem enhancement New feature or request

Comments

@yualan
Copy link

yualan commented Oct 24, 2019

Hi Team,

My name is Alan Yu, a PM from Microsoft on the SQL Server team. We are working on Azure Data Studio, which is a cross-platform, multi-DB tool for managing data. Azure Data Studio is a fork of Visual Studio Code and is optimized for data-related experiences. This includes support of full GUI features such as Wizards, Dashboards, and Notebook viewers which differentiates from VS Code.

In both Azure Data Studio and VS Code, extensions are supported in the same way through VSIX files. This means many VS Code extensions will also work as is in Azure Data Studio. We have examples of this such as the Powershell extension, theme extension, etc. that are featured in the Azure Data Studio marketplace.

We are reaching out to you to see if you would be interested in having the Scala extension also appear in the Azure Data Studio extension. From our initial testing, the extension works as is from doing Install from VSIX. The work to support this would be a separate ReadMe, similar to what the Powershell team did, and would help the Scala extension reach out database and data science user base.

Let us know if this is something you are interested in. You can also reach out to me at [email protected]

Thank you,
Alan Yu

@nicolasstucki
Copy link
Contributor

Sounds interesting, but I do not use or know that platform.

If someone else is interested, please let us know.

@nicolasstucki nicolasstucki added enhancement New feature or request help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Nov 7, 2019
@olafurpg
Copy link
Contributor

olafurpg commented Jan 6, 2020

@yualan Thank you for reaching out! This sounds interesting and we would be happy to having the Scala extension appear in the Azure Data Studio extension.

The work to support this would be a separate ReadMe, similar to what the Powershell team did, and would help the Scala extension reach out database and data science user base.

Can you please elaborate on this? What exact steps are necessary to make this happen?

@yualan
Copy link
Author

yualan commented Jan 8, 2020

Hi Olafur, thanks for your response. To clarify, if you would like to have two separate readme's: one for VS Code and one for Azure Data Studio, then all you would need to do is create another readme and send us the file path to the readme. Otherwise, if you feel like there won't be any changes between the scala experience in VS Code or Azure Data Studio, then you can follow our publishing instructions here: https://docs.microsoft.com/sql/azure-data-studio/extension-authoring?view=sql-server-ver15#publish-an-extension

Let us know if you have any questions and we are happy to help.

@olafurpg
Copy link
Contributor

olafurpg commented Jan 22, 2020

We currently automatically release the VS Code extension on git tag push from CI using the vsce command-line interface. See

yarn vscode:publish -p $VS_MARKETPLACE_TOKEN

Is there any equivalent tool for Azure Data Studio? I'm afraid that if we have to publish the extension manually from a maintainer's personal computer then the extension will quickly get out of date.

@yualan
Copy link
Author

yualan commented Jan 22, 2020

Hi Olafur, currently Azure Data Studio does not have a CI system to automate extension publishing. You or another maintainer will need to submit a PR when a new release is ready: https://docs.microsoft.com/sql/azure-data-studio/extension-authoring?view=sql-server-ver15#publish-an-extension

However, we are planning an effort to improve this support later this year. I would like to see how users are engaging with the extension, and then we can let you know when we have automated extension publishing. Does this work?

@olafurpg
Copy link
Contributor

Would it be possible for you to publish the extension for us? It's not obvious to me how to submit a valid PR. I tried to take inspiration from other PRs like https://github.com/microsoft/azuredatastudio/pull/2182/files but the diff is very large.

We're happy to respond to issues from users. The publishing step just feels a bit overwhelming compared to VS Code.

@yualan
Copy link
Author

yualan commented Feb 24, 2020

Hi @olafurpg, sorry for the delay. @alanrenmsft would be happy to help with publishing the extension.

Before starting the process, we noticed the ReadMe has VS Code on there. I can submit a PR for a separate ReadMe for ADS if that works for you?

Let us know how we can help.

@nicolasstucki
Copy link
Contributor

Hi @yualan that would work for us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ecosystem enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants