Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't report problems if origin files do not exist anymore #762

Closed
jvican opened this issue Dec 17, 2018 · 2 comments
Closed

Don't report problems if origin files do not exist anymore #762

jvican opened this issue Dec 17, 2018 · 2 comments
Labels
bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP. task / compile

Comments

@jvican
Copy link
Contributor

jvican commented Dec 17, 2018

See https://twitter.com/channingwalton/status/1074592345256017920

@jvican jvican added bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP. task / compile labels Dec 17, 2018
@jvican jvican changed the title Don't report problems if the origin files do not exist anymore Don't report problems if origin files do not exist anymore Dec 17, 2018
@olafurpg
Copy link
Contributor

Steps to reproduce

  • create file A.scala
  • add compile error to A.scala
  • diagnostics are published as expected
{
  "method": "textDocument/publishDiagnostics",
  "params": {
    "uri": "file:///Users/olafurpg/dev/metals/tests/unit/src/test/scala/tests/BspSwitchSlowSuite.scala",
    "diagnostics": [
      {
    ...
        "message": "type mismatch;\n found   : String(\"\")\n required: Int"
      }
    ]
  }
}
  • remove A.scala
  • expected a publishDiagnostics notification with reset=true and diagnostics=[] for A.scala, but obtained no notification.

@channingwalton
Copy link

Awesome, thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect or misbehaviour. build server Any issue or pull request that has to do with hot compilers or BSP. task / compile
Projects
None yet
Development

No branches or pull requests

3 participants