bugfix: Compile only existing classes #2490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgodzik
force-pushed
the
compile-existing
branch
from
d312a27 to
054f826
Compare
tgodzik
force-pushed
the
compile-existing
branch
from
054f826 to
1415473
Compare
tgodzik
commented
Nov 1, 2024
| @@ -231,21 +238,22 @@ private final class BloopNameHashing( | |||
| } | |||
|
|
|||
| def recompileClasses( | |||
| sources: Set[VirtualFile], | |||
| currentInvalidatedSources: Set[VirtualFile], | |||
There was a problem hiding this comment.
This is the main change, we would previously send all invalidated files even if they were no longer contained in the sources. This make sense for class files to remove them, but no some much to compile new files.
With this change I was no longer able to reproduce the issue in Metals where we would get old compilation artifacts somehow.
| ) | ||
| } | ||
|
|
||
| loadBspState(workspace, projects, logger) { state => |
There was a problem hiding this comment.
I haven't been able to reproduce the issue in the test unfortunately, this seems somehow connected to multiple thing being done at the same time via metals and VS Code, but the change in BloopNameHashing is sound anyway.
And having this test won't hurt
Previously, we would ask zinc to compile even a file that was removed and I think this was causing scalameta/metals#6478 Now, we invalidated all changed sources, but only compile new ones.
tgodzik
force-pushed
the
compile-existing
branch
from
1415473 to
c8e9623
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would ask zinc to compile even a file that was removed and I think this was causing scalameta/metals#6478
Now, we invalidated all changed sources, but only compile new ones.