Switch http client from apache-http to asynchttpclient #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adpi2
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Thanks for the PR!
I used gigahorse-apache-http because it is already used by sbt itself (here) and I want to limit the number of dependencies to the bare minimum to avoid conflicts with other plugins.
However it seems that gigahorse-asynchttpclient uses a shaded version of async-http-client. So I am fine with it.
|
Hey, do you have plans to cut a new release soon? I don't want to put you pressure, but since I need this change I'm trying to figure out if i should have a temporary private fork for this meanwhile. Thanks in advance! |
|
The release is in progress: https://github.com/scalacenter/sbt-dependency-submission/actions/runs/6860820101 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is to fix #144