You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
withCoproductInstance[Subtype] matches on source type
.matching[Subtype] matches on target type
yet both are using the same Matching[Type] path segment when defining override
this could be fixed by
spliting Matching case into SourceMatching and TargetMatching
having overrides in SealeHierarchyToSealedHierarchy distinct which type is being matched
updating filterCurrentOverridesForSubtype(typeFilter: ?? => Boolean) to filter by both source and target type on respective fields
This is not super critical now - most of the time use cases would prevent any issues from happening - but it should be fixed before 1.0.0-RC1 since it requires a breaking change.
The text was updated successfully, but these errors were encountered:
I just figures out that I messed up in 1.0.0-M5:
withCoproductInstance[Subtype]
matches on source type.matching[Subtype]
matches on target typeMatching[Type]
path segment when defining overrideMatching
case intoSourceMatching
andTargetMatching
SealeHierarchyToSealedHierarchy
distinct which type is being matchedfilterCurrentOverridesForSubtype(typeFilter: ?? => Boolean)
to filter by both source and target type on respective fieldsThis is not super critical now - most of the time use cases would prevent any issues from happening - but it should be fixed before 1.0.0-RC1 since it requires a breaking change.
The text was updated successfully, but these errors were encountered: