-
-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More Cats instances (for Chimney types, NOT Chimney instances for Cats data) #443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateuszKubuszok
added
breaking change
Change resulting in compilation errors of code that used to be considered correct, or linking errors
blocked
Ticket cannot be implemented because it depends on another ticker or external factor
labels
Dec 12, 2023
MateuszKubuszok
changed the title
More Cats instances
More Cats instances (for Chimney types, NOT Chimney instances for Cats data)
Dec 13, 2023
MateuszKubuszok
force-pushed
the
more-cats
branch
from
January 9, 2024 22:53
8fe5ab8
to
f3874e8
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #443 +/- ##
==========================================
+ Coverage 85.42% 85.77% +0.34%
==========================================
Files 122 124 +2
Lines 5180 5342 +162
Branches 205 213 +8
==========================================
+ Hits 4425 4582 +157
- Misses 755 760 +5 ☔ View full report in Codecov by Sentry. |
MateuszKubuszok
force-pushed
the
more-cats
branch
from
January 10, 2024 09:21
bd32c42
to
cf2f9fc
Compare
MateuszKubuszok
force-pushed
the
more-cats
branch
from
January 11, 2024 10:57
ba6e15d
to
7311374
Compare
MateuszKubuszok
removed
the
blocked
Ticket cannot be implemented because it depends on another ticker or external factor
label
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
Change resulting in compilation errors of code that used to be considered correct, or linking errors
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
Transformer
laws' testsPartialTransformer
laws' testspartial.Result
laws' teststoPartialResult
extension methods withAsResult
instances frompartial.syntax
This is probably a breaking change:
partial.Result
had onlyApplicative
instance, which is now expanded toMonadError[partial.Result, partial.Result.Errors] & CoflatMap[partial.Result] & Traverse[partial.Result]
Applicative
extends among othersSemigroupal
- the oldApplicative
had a parallel semanticsMonad
and friends it has to be sequential (and monadic laws would check that most likely)Semigroupal
relies on parallel semantics - we can create a separate instance with a higher implicit priority and thus achieve source compatibility (and this makes tests pass again)applicativePartialResult
implicit would have a changed behavior during eviction (one which fails fast and have less errors)