Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More nested-path functionalities #493

Merged
merged 20 commits into from
Apr 10, 2024
Merged

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Apr 5, 2024

The goal of this PR is to enable paths like:

  • _.matching[Foo]
  • _.matchingSome
  • _.matchingLeft
  • _.matchingRight
  • _.everyItem
  • _.everyMapKey
  • _.everyMapValue

expanding the work started in #358.

This was unblocked by the work done in #490. The remaining works to do is to:

  • provide missing Path cases in phantom type
  • provide missing Path cases in TransformationConfig
  • parsing Path phantom type into Path in TransformationConfig
  • creating extension methods in DSL
  • parsing extension methods by DSL macros
    • Scala 2
    • Scala 3
  • test
    • products
    • DSL errors
    • std lib (iterables, maps, arrays)
  • write documentation
  • @implicitNotFound for evidence
  • @compileTimeOnly for extension methods

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 89.97722% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 90.43%. Comparing base (7436716) to head (d1a0d40).
Report is 1 commits behind head on master.

Files Patch % Lines
...ey/internal/compiletime/ChimneyTypesPlatform.scala 57.14% 9 Missing ⚠️
...internal/compiletime/dsl/utils/DslMacroUtils.scala 88.23% 6 Missing ⚠️
...rmSealedHierarchyToSealedHierarchyRuleModule.scala 75.00% 5 Missing ⚠️
...ain/scala-2/io/scalaland/chimney/dsl/package.scala 0.00% 3 Missing ⚠️
...internal/compiletime/dsl/utils/DslMacroUtils.scala 95.71% 3 Missing ⚠️
...al/compiletime/derivation/patcher/Derivation.scala 91.42% 3 Missing ⚠️
.../scalaland/chimney/internal/runtime/IsEither.scala 0.00% 3 Missing ⚠️
...ernal/compiletime/datatypes/IterableOrArrays.scala 92.00% 2 Missing ⚠️
...ey/internal/compiletime/ChimneyTypesPlatform.scala 92.00% 2 Missing ⚠️
...letime/derivation/transformer/Configurations.scala 94.44% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #493      +/-   ##
==========================================
+ Coverage   90.34%   90.43%   +0.08%     
==========================================
  Files         125      129       +4     
  Lines        4806     5059     +253     
  Branches      440      445       +5     
==========================================
+ Hits         4342     4575     +233     
- Misses        464      484      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…figs, updated MapToMap rule to handle overrides
…la 3 to something which works better in IDE, add compileTimeOnly/inline+compiletime.error for DSL methods intended to use only within DSL
@MateuszKubuszok MateuszKubuszok changed the title More nested path functionalities More nested-path functionalities Apr 10, 2024
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review April 10, 2024 20:59
@MateuszKubuszok MateuszKubuszok merged commit b71778f into master Apr 10, 2024
22 of 23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the better-nested-paths branch April 10, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant