Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround for withConstructorPartial and use a proper solution #508

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Apr 18, 2024

I'll add a proper unit test later

@MateuszKubuszok MateuszKubuszok added this to the 1.0.0-RC milestone Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.07%. Comparing base (824d96a) to head (81f7eee).

Files Patch % Lines
...er/rules/TransformProductToProductRuleModule.scala 90.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master     #508   +/-   ##
=======================================
  Coverage   90.07%   90.07%           
=======================================
  Files         128      128           
  Lines        5099     5100    +1     
  Branches      439      443    +4     
=======================================
+ Hits         4593     4594    +1     
  Misses        506      506           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit 38166d6 into master Apr 18, 2024
23 checks passed
@MateuszKubuszok MateuszKubuszok deleted the partial-constructor-fixes branch April 18, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant