Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the last internal utility from the public API #540

Merged
merged 1 commit into from
May 22, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented May 22, 2024

Let's test if private[chimney] fails MiMa check (it should be binary compatible)?

EDIT: it seems it does.

  • Result.Errors.__mergeResultNullable is an utility we need for performance (it allow us to avoid allocations, since we can just use var and null when we have no errors to report)
  • we cannot remove it for backward compatibility reasons
  • but also showing users the method __mergeResultNullable with docs "Please do not use" (which is not defined in internal package), is rather ugly

so we can use some redirection to make it package private - for JVM it is still public but it should no longer be directly usable/no longer shown by IDE.

@MateuszKubuszok MateuszKubuszok force-pushed the hide-one-internal-boi branch from 0e0c03f to 3415ae6 Compare May 22, 2024 04:06
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.67%. Comparing base (0986cda) to head (3415ae6).
Report is 122 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #540      +/-   ##
==========================================
- Coverage   87.72%   87.67%   -0.05%     
==========================================
  Files         136      137       +1     
  Lines        5440     5468      +28     
  Branches      455      442      -13     
==========================================
+ Hits         4772     4794      +22     
- Misses        668      674       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MateuszKubuszok MateuszKubuszok merged commit 57ead77 into master May 22, 2024
23 of 24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the hide-one-internal-boi branch May 22, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant