Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better singleton types support #559

Merged
merged 13 commits into from
Jul 4, 2024
Merged

Better singleton types support #559

merged 13 commits into from
Jul 4, 2024

Conversation

MateuszKubuszok
Copy link
Member

@MateuszKubuszok MateuszKubuszok commented Jun 28, 2024

TODO:

  • utilities for literal singletons (Boolean, Int, Long, Float, Double, Char, String)
  • Singleton datatype aggregating: literal singletons, (), null, .type and objects
  • rule transforming into Singleton type (excluding None and Unit, with explanation)
  • fallback on Singleton type (instead of just Unit, excluding None - document why)
  • tests
    • fill Null (all)
    • fill literal-based singleton types (2.13/3)
    • fill case object (all)
    • fill Enum.Value.type (3)
    • into Null (all)
    • into literal-based singleton types (2.13/3)
    • into case object (all)
    • into Enum.Value.type (3)
  • docs

@MateuszKubuszok MateuszKubuszok linked an issue Jun 28, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jun 28, 2024

Codecov Report

Attention: Patch coverage is 87.30159% with 8 lines in your changes missing coverage. Please review.

Project coverage is 87.77%. Comparing base (ae098a6) to head (da2ed8f).
Report is 89 commits behind head on master.

Files with missing lines Patch % Lines
...nternal/compiletime/datatypes/SingletonTypes.scala 86.95% 3 Missing ⚠️
...d/chimney/internal/compiletime/TypesPlatform.scala 84.61% 2 Missing ⚠️
.../chimney/integrations/PartiallyBuildIterable.scala 0.00% 2 Missing ⚠️
...scalaland/chimney/internal/compiletime/Types.scala 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #559      +/-   ##
==========================================
+ Coverage   87.57%   87.77%   +0.19%     
==========================================
  Files         149      151       +2     
  Lines        5845     5899      +54     
  Branches      489      494       +5     
==========================================
+ Hits         5119     5178      +59     
+ Misses        726      721       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…eral-based singletons for Total Transformers on 2.13/3
@MateuszKubuszok MateuszKubuszok marked this pull request as ready for review July 4, 2024 07:24
@MateuszKubuszok MateuszKubuszok merged commit aa7a895 into master Jul 4, 2024
23 of 24 checks passed
@MateuszKubuszok MateuszKubuszok deleted the singleton-types branch July 4, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transform into singleton types
1 participant