Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resizing is not taken into account when using getCurrentImgDataFnRef #344

Closed
jducro opened this issue Jun 2, 2023 · 5 comments
Closed
Labels
bug Something isn't working Released The issue is fixed/considered and released

Comments

@jducro
Copy link
Contributor

jducro commented Jun 2, 2023

As our ui requires a different save button, we are using :

editorInstance().imageData.imageBase64;

With editorInstance being the ref provided by getCurrentImgDataFnRef.

However after a resize the imageData is not affected at all by the resize.

Is that a bug or do we missing some configuration to get the resized image from that ref?

Thanks a lot.

@AhmeeedMostafa
Copy link
Collaborator

could u please explain more ur steps as they are not pretty clear for me?
u should call the function that has been assigned in ur provided ref whenever u need the current image data.
the returned image data from that function are the same data provided on clicking save normally.

@AhmeeedMostafa AhmeeedMostafa added the TBD To Be Defined means that issue needs to be checked and re-labeled after checking label Jun 4, 2023
@jducro
Copy link
Contributor Author

jducro commented Jun 5, 2023

Here's a sandbox of what I'm facing:
https://codesandbox.io/s/cool-sunset-zshw6l?file=/src/App.tsx
If you do a resize and press the save button I added, the original size is showing. imageData from that ref is unaffected by resizing.

@AhmeeedMostafa AhmeeedMostafa added bug Something isn't working Waiting release The issue's code is added in the dev. branch but not yet released and removed TBD To Be Defined means that issue needs to be checked and re-labeled after checking labels Jun 6, 2023
@AhmeeedMostafa
Copy link
Collaborator

@jducro clear now, seems a bug... fixed and will be considered in the upcoming release.

@jducro
Copy link
Contributor Author

jducro commented Jun 8, 2023

Thanks @AhmeeedMostafa ! Do you have an ETA on the next release?

@AhmeeedMostafa
Copy link
Collaborator

It is released @jducro

@AhmeeedMostafa AhmeeedMostafa added Released The issue is fixed/considered and released and removed Waiting release The issue's code is added in the dev. branch but not yet released labels Jun 9, 2023
@jducro jducro closed this as completed Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Released The issue is fixed/considered and released
Projects
None yet
Development

No branches or pull requests

2 participants