Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure backbeat retrieve the account quotas #5712

Merged
merged 8 commits into from
Dec 8, 2024
Merged

Ensure backbeat retrieve the account quotas #5712

merged 8 commits into from
Dec 8, 2024

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Dec 6, 2024 •
edited by francoisferrand
Loading

Fix for Quota during expiration

Issue: CLDSRV-590

@bert-e
Copy link
Contributor

bert-e commented Dec 6, 2024

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@williamlardier
Copy link
Contributor Author

williamlardier commented Dec 6, 2024 •
edited by francoisferrand
Loading

/approve

@francoisferrand francoisferrand force-pushed the bugfix/CLDSRV-590 branch 4 times, most recently from 419848b to ee4e931 Compare December 7, 2024 01:11
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-590 branch 2 times, most recently from cebf5ba to b89cc93 Compare December 7, 2024 02:28
@francoisferrand francoisferrand force-pushed the bugfix/CLDSRV-590 branch 4 times, most recently from 0c70f0e to 6d20262 Compare December 7, 2024 22:48
@williamlardier @francoisferrand
Ensure backbeat retrieve the account quotas
17fa51d 
The route backbeat also calls the doAuth function, but we never
map the value to accountQuotas

Issue: CLDSRV-590
@williamlardier @francoisferrand
Ensure we pass the right action name for delete object APIs
ddc6044 
From backbeat routes, all APIs will use a name we only need for
monitoring, but the action name is actually used during the
quota evalutation (and possibly bucket policy as well).

Issue: CLDSRV-590
@scality scality deleted a comment from bert-e Dec 7, 2024
@francoisferrand
Track inflights for backbeat's batchDelete route
147f7e1 
This is needed to track deletions in case of transition or restored
object expiration.

Issue: CLDSRV-590
williamlardier and others added 3 commits December 8, 2024 01:46
@williamlardier @francoisferrand
Ensure we follow the right return variables from doAuth
8faf9b3 
BB routes are not authorizing internal API calls. To
be adressed in CLDSRV-591

Issue: CLDSRV-590
@francoisferrand
Fix quota inflights for cold objects
7149ef5 
Deleting cold objects should not increment inflight, unless they are
restored.

Issue: CLDSRV-590
@francoisferrand
Fix inflight handling for multiObjectDelete
5b40bb3 
Issue: CLDSRV-590
@francoisferrand francoisferrand force-pushed the bugfix/CLDSRV-590 branch 2 times, most recently from c9879bb to 48b8012 Compare December 8, 2024 01:36
@bert-e
Copy link
Contributor

bert-e commented Dec 8, 2024

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue CLDSRV-590.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit a240104 into development/8.8 Dec 8, 2024
16 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-590 branch December 8, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francoisferrand francoisferrand francoisferrand approved these changes

@benzekrimaha benzekrimaha benzekrimaha approved these changes

@rachedbenmustapha rachedbenmustapha Awaiting requested review from rachedbenmustapha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@williamlardier @bert-e @francoisferrand @benzekrimaha