Small rusty cleanup #228
Merged
Small rusty cleanup #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some random issues in the code, like unused variables, and bad print formatters. I'm not sure why the compiler isn't consistently complaining, but let's fix them. Signed-off-by: David Vernet <[email protected]>
We have a lot of boilerplate code where we create a cpumask, initialize it, and then bpf_kptr_xchg() it into the map. In an effort to slightly reduce the amount of boilerplate, let's create a helper that can alleviate some of it. Signed-off-by: David Vernet <[email protected]>
It doesn't need to be a global prog. Let's make it static. Signed-off-by: David Vernet <[email protected]>
Getting rid of more boilerplate Signed-off-by: David Vernet <[email protected]>
htejun
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed a few things that could be cleaned up and/or fixed. Mostly just gets rid of
ugly boilerplate, but also fixes some issues that for some reason the compiler
wasn't noticing; like unused variables, and improper print formatting.