scx_layered: Add Big/Little core growth algos #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add extra ordering macros for Core/CPU structs for ease of use with Rust standard library features. This issue was hit when trying to sort cores based on the CoreType. See this similar issue for details: rust-lang/rust#113550 Signed-off-by: Daniel Hodges <[email protected]>
|
I will test this when I get back from LPC on some actual hardware to make sure the ordering is correct. |
hodgesds
force-pushed
the
layered-pcore-grow
branch
from
2572d8f
to
a3d1344
Compare
Add core growth algos for Big/Little core support. The algos allow layers to grow layers by preferring either big or little cores first. Signed-off-by: Daniel Hodges <[email protected]>
hodgesds
commented
Sep 20, 2024
| @@ -99,13 +99,13 @@ lazy_static::lazy_static! { | |||
| pub static ref NR_CPUS_POSSIBLE: usize = libbpf_rs::num_possible_cpus().unwrap(); | |||
| } | |||
|
|
|||
| #[derive(Debug, Clone, Eq, Hash, PartialEq)] | |||
| #[derive(Debug, Clone, Eq, Hash, Ord, PartialEq, PartialOrd)] | |||
There was a problem hiding this comment.
added the extra sorting macros because I ran into this when trying to sort by CoreType.
|
Sorting works properly: The pcores on the tested machine (Intel i3-1220P) are ordered correctly: |
htejun
approved these changes
Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add layer growth algos for big/little core topologies that prefer one core type. Discussed this with @JakeHillion at LPC as another way to grow layers.