-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scx_layered: Restrict preemption to layer cpumask #681
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When preempting restrict preemption to the current layer cpumask. This may reduce the amount of preemption, but cause better cache locality of preempted tasks. Signed-off-by: Daniel Hodges <[email protected]>
hodgesds
commented
Sep 24, 2024
/* | ||
* First try preempting in the local LLC | ||
*/ | ||
bpf_for(idx, 0, cachec->nr_cpus) { | ||
s32 preempt_cpu = bpf_cpumask_any_distribute(cast_mask(topo_cpus)); | ||
trace("PREEMPT attempt on cpu %d from cpu %d", | ||
preempt_cpu, bpf_get_smp_processor_id()); | ||
if (preempt_cpu > cachec->nr_cpus) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
drive by fix, this check is wrong and not needed
lgtm, a comment explaining the mask manipulation would be nice though |
likewhatevs
approved these changes
Sep 24, 2024
Tested with
|
Update comments on layer preemption to be more descriptive. Signed-off-by: Daniel Hodges <[email protected]>
htejun
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When preempting restrict preemption to the current layer cpumask. This may reduce the amount of preemption, but cause better cache locality of preempted tasks.