clean up ci/make ci nicer #682
Conversation
Replace build scheds and merged with caching build, and rename caching build to build-and-test. This should make the CI reports on PRs be nice and specific (i.e. at a glance, know what passes and what fails). It also keeps PR CI jobs up to date (as folks edit things) and has them all use one config/24.04 etc.
|
Github CI is running the PR config in this PR on this PR so we can see if we like it/if it is better. |
the defaults for the pr ci runs look good, they are "run on open/reopen/update code", so use those.
likewhatevs
force-pushed
the
ci-update
branch
from
548ffe2
to
0103656
Compare
|
I think this works (comment is to see if I generate a ton more jobs, just checking). |
|
Some drive by comments on the CI as this diff brought them to mind:
Otherwise, I think these checks are way more useful than a mega check with far too much output. |
| build-kernel: | ||
| runs-on: ubuntu-24.04 | ||
| steps: | ||
| # prevent cache permission errors |
There was a problem hiding this comment.
Why is this needed everywhere? Is the base image bad?
There was a problem hiding this comment.
Why is this needed everywhere? Is the base image bad?
Ehh, bad is a strong term. I'd argue the cache action is not very good for leaving that foot-gun in (everywhere cuz someone will get it wrong in the future otherwise).
| @@ -185,6 +210,8 @@ jobs: | |||
| matrix: | |||
| scheduler: [ scx_bpfland, scx_lavd, scx_layered, scx_rlfifo, scx_rustland, scx_rusty ] | |||
| steps: | |||
| # prevent cache permission errors | |||
| - run: sudo chown root /usr/bin/tar && sudo chmod u+s /usr/bin/tar | |||
| - uses: actions/checkout@v4 | |||
| - uses: ./.github/actions/install-deps-action | |||
| # cache virtiofsd (goes away w/ 24.04) | |||
There was a problem hiding this comment.
We can probably add the per scheduler veristat meson script as well to this. That way if there is a verifier error it will be in the test for the scheduler as well as in the integration test.
There was a problem hiding this comment.
I'd add that separately because that might have flakiness of it's own/I haven't seen that run on CI a lot (i.e. to goal of this is mainly to make CI output more useful while one scheduler is broken + ensure caching works right so queuing doesn't become an issue).
I agree w/ this, but wouldn't tackle it here (i.e. we've seen the current set up run for a while, this is mainly splitting that, that should be added separately IMO).
I think so. That prevents issues from ending up there (like the SM_IDLE one) IMO.
I agree w/ this, but wouldn't tackle it here (i.e. we've seen the current set up run for a while, this is mainly splitting that, that should be added separately IMO). Moreso w/ this one because there could be packaging issues etc. |
Replace build scheds and merged with caching build, and rename caching build to build-and-test.
This should make the CI reports on PRs be nice and specific (i.e. at a glance, know what passes and what fails).
It also keeps PR CI jobs up to date (as folks edit things) and has them all use one config/24.04 etc.