Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "scx_rustland_core: prevent deadlock with per-CPU DSQs and CPU… #706

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

arighi
Copy link
Contributor

@arighi arighi commented Sep 29, 2024

… affinity"

It seems that with the latest kernel the per-CPU DSQ stall while executing sched_setaffinity() doesn't happen anymore.

Therefore, get rid of the temporary workaround introduced by commit 86db45f ("scx_rustland_core: prevent deadlock with per-CPU DSQs and CPU affinity") and restore the old behavior, which offers more fair scheduling policy.

… affinity"

It seems that with the latest kernel the per-CPU DSQ stall while
executing sched_setaffinity() doesn't happen anymore.

Therefore, get rid of the temporary workaround introduced by commit
86db45f ("scx_rustland_core: prevent deadlock with per-CPU DSQs and CPU
affinity") and restore the old behavior, which offers more fair
scheduling policy.

Signed-off-by: Andrea Righi <[email protected]>
Copy link
Contributor

@hodgesds hodgesds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arighi arighi added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 55913e7 Sep 30, 2024
37 of 38 checks passed
@arighi arighi deleted the rustland-core-drop-setaffinity-workaround branch September 30, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants