Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_layered: Fix verifier errors #768

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

hodgesds
Copy link
Contributor

@hodgesds hodgesds commented Oct 9, 2024

Fix verifier errors when using different DSQ iteration algorithms and cleanup some code.

weight:

$ sudo ./target/release/scx_layered  f:/home/hodgesd/user.json --dsq-iter-algo  weight 
21:38:05 [INFO] CPUs: online/possible=176/176 nr_cores=88
21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_init not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_exit not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_prep_move not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_move not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_cancel_move not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] libbpf: struct_ops layered: member cgroup_set_weight not found in kernel, skipping it as it's set to zero

21:38:05 [INFO] Layered Scheduler Attached. Run `scx_layered --monitor` for metrics.
^CEXIT: Scheduler unregistered from user space

linear:

$ sudo ./target/release/scx_layered  f:/home/hodgesd/user.json --dsq-iter-algo  linear 
21:38:36 [INFO] CPUs: online/possible=176/176 nr_cores=88
21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_init not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_exit not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_prep_move not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_move not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_cancel_move not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] libbpf: struct_ops layered: member cgroup_set_weight not found in kernel, skipping it as it's set to zero

21:38:36 [INFO] Layered Scheduler Attached. Run `scx_layered --monitor` for metrics.
^CEXIT: Scheduler unregistered from user space

round_robin:

]$ sudo ./target/release/scx_layered  f:/home/hodgesd/user.json --dsq-iter-algo  round_robin
21:39:07 [INFO] CPUs: online/possible=176/176 nr_cores=88
21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_init not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_exit not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_prep_move not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_move not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_cancel_move not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] libbpf: struct_ops layered: member cgroup_set_weight not found in kernel, skipping it as it's set to zero

21:39:07 [INFO] Layered Scheduler Attached. Run `scx_layered --monitor` for metrics.
^CEXIT: Scheduler unregistered from user space

weight no topo:

$ sudo ./target/release/scx_layered  f:/home/hodgesd/user.json --dsq-iter-algo  weight -t
21:39:36 [INFO] Disabling topology awareness
21:39:36 [INFO] CPUs: online/possible=176/176 nr_cores=88
21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_init not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_exit not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_prep_move not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_move not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_cancel_move not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] libbpf: struct_ops layered: member cgroup_set_weight not found in kernel, skipping it as it's set to zero

21:39:36 [INFO] Layered Scheduler Attached. Run `scx_layered --monitor` for metrics.
^CEXIT: Scheduler unregistered from user space

Fix verifier errors when using different DSQ iteration algorithms and
cleanup some code.

Signed-off-by: Daniel Hodges <[email protected]>
@hodgesds hodgesds added this pull request to the merge queue Oct 9, 2024
Merged via the queue into sched-ext:main with commit 4b817dc Oct 9, 2024
19 checks passed
@hodgesds hodgesds deleted the layered-verifier-fix branch October 9, 2024 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants