Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jms_job_safe_object deprecation warning triggered in bundle extension #231

Open
bluser86 opened this issue Jun 27, 2019 · 5 comments
Open

Comments

@bluser86
Copy link

bluser86 commented Jun 27, 2019

The bundle extension triggers a deprecation warning when configuring the "jms_job_safe_object" doctrine type.

    public function prepend(ContainerBuilder $container)
    {
        $container->prependExtensionConfig('doctrine', array(
            'dbal' => array(
                'types' => array(
                    'jms_job_safe_object' => array(
                        'class' => SafeObjectType::class,
                        'commented' => true,
                    )
                )
            )
        ));
    }

The received deprecation warning is emitted by the \Doctrine\Bundle\DoctrineBundle\ConnectionFactory:

User Deprecated: The type "jms_job_safe_object" was explicitly marked as commented in its configuration. This is no longer necessary and will be removed in DoctrineBundle 2.0. Please remove the "commented" attribute from the type configuration.

Our current version of the job queue bundle is 1.4.3 and the doctrine bundle is 1.11.2.

@const-nawata
Copy link

I use the last version of this bundle (^2.0) and have the same warning. I think, it is necessary to change type from 'jms_job_safe_object' to another one at vendor/jms/job-queue-bundle/JMS/JobQueueBundle/Entity/Job.php, line 161.

@cve
Copy link

cve commented Jul 18, 2019

With docker runing bin/console is stale

@curtchan
Copy link

curtchan commented Aug 1, 2019

Won't removing 'commented' => true be enough?

@dczech
Copy link

dczech commented Feb 17, 2021

according to doctrine/DoctrineBundle#977 'commented' => true should be removed and

public function requiresSQLCommentHint(AbstractPlatform $platform) : bool
    {
        return true;
    }

should be added to type class

@tommym9
Copy link

tommym9 commented Jan 19, 2023

Could this changed be rolled into a new release? I'm on the 2.1.0 version of this and getting this warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants