-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection Objects for Xml Serialization #124
Comments
I agree on not treating Traversables specially. Did you already work on a patch for this? Regarding the entry name, I'm not sure, it could add some amount of performance penalty since we would have to determine it for each object separately, and then also support the generation in both directions. It gets even more complicated if someone uses the "inline" option in which case we do not even know to which property the entry would belong. |
As I need something like @lsmith pointed out in #48 I've taken a crack at it what seemed to be possible. |
This should now be possible in the same fashion as #117 (see my comments there). |
This expands on GH-117.
I introduced a collection object into my code. The following approaches failed:
It seems traversables get special handling in the GraphNavigator#104. I think this should not be the case if the metadata of the traversable is not null.
Additionally to solve the "" problem in xml serialization, there should somehow be a way to at least replace with something, i think the XmlSerializervisitor could use the root element name as entryName of each value somehow in visitArray(). That would even allow serialization of inheritances:
Ping @lsmith77
The text was updated successfully, but these errors were encountered: