Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Properties Created #114

Open
mbabker opened this issue Aug 3, 2023 · 0 comments
Open

Dynamic Properties Created #114

mbabker opened this issue Aug 3, 2023 · 0 comments

Comments

@mbabker
Copy link
Contributor

mbabker commented Aug 3, 2023

Q A
Bug report? no
Feature request? no
BC Break report? no
RFC? no

Running the test suite locally on PHP 8.2 (which isn't covered in CI right now) with #113 gives this output:

$ vendor/bin/phpunit 
PHPUnit 9.6.10 by Sebastian Bergmann and contributors.

Warning:       Your XML configuration validates against a deprecated schema.
Suggestion:    Migrate your XML configuration using "--migrate-configuration"!

SS................................................WPHP Deprecated:  Creation of dynamic property Metadata\MethodMetadata::$unknownProperty is deprecated in /Users/mbabker/Sites/metadata/src/MethodMetadata.php on line 68
.
Deprecated: Creation of dynamic property Metadata\MethodMetadata::$unknownProperty is deprecated in /Users/mbabker/Sites/metadata/src/MethodMetadata.php on line 68
..

Time: 00:04.136, Memory: 8.00 MB

There was 1 warning:

1) Metadata\Tests\MethodMetadataTest::testReadAccessForUnknownProperty
Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10.

WARNINGS!
Tests: 55, Assertions: 117, Warnings: 1, Skipped: 2.

The PHPUnit deprecation can be dealt with at a later point as it only affects the testing environment, but the dynamic property creation in the Metadata\MethodMetadata class introduced via #78 should be reviewed at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant