From dddb91a673c3e1263880d32a54df034350617f59 Mon Sep 17 00:00:00 2001
From: Greg Tyler <greg.tyler@digital.justice.gov.uk>
Date: Mon, 18 Nov 2024 09:46:27 +0000
Subject: [PATCH] Add end to end tests for False types

From `ea7f7be4cb6ca2d1ed5e156b57f1413be8936e82`, but I can't cherry-pick because it's cross-remote
---
 .../DeserializationGraphNavigator.php         |  2 ++
 tests/Fixtures/DataFalse.php                  | 13 +++++++++
 tests/Fixtures/DataTrue.php                   | 10 +++++++
 tests/Serializer/JsonSerializationTest.php    | 27 +++++++++++++++++++
 4 files changed, 52 insertions(+)
 create mode 100644 tests/Fixtures/DataFalse.php
 create mode 100644 tests/Fixtures/DataTrue.php

diff --git a/src/GraphNavigator/DeserializationGraphNavigator.php b/src/GraphNavigator/DeserializationGraphNavigator.php
index a29e43c12..edf1e6a68 100644
--- a/src/GraphNavigator/DeserializationGraphNavigator.php
+++ b/src/GraphNavigator/DeserializationGraphNavigator.php
@@ -128,6 +128,8 @@ public function accept($data, ?array $type = null)
 
             case 'bool':
             case 'boolean':
+            case 'false':
+            case 'true':
                 return $this->visitor->visitBoolean($data, $type);
 
             case 'double':
diff --git a/tests/Fixtures/DataFalse.php b/tests/Fixtures/DataFalse.php
new file mode 100644
index 000000000..ce3d2632f
--- /dev/null
+++ b/tests/Fixtures/DataFalse.php
@@ -0,0 +1,13 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures;
+
+class DataFalse
+{
+    public function __construct(
+        public false $data
+    ) {
+    }
+}
diff --git a/tests/Fixtures/DataTrue.php b/tests/Fixtures/DataTrue.php
new file mode 100644
index 000000000..0bfe05b68
--- /dev/null
+++ b/tests/Fixtures/DataTrue.php
@@ -0,0 +1,10 @@
+<?php
+
+declare(strict_types=1);
+
+namespace JMS\Serializer\Tests\Fixtures;
+
+class DataTrue
+{
+    public true $data;
+}
diff --git a/tests/Serializer/JsonSerializationTest.php b/tests/Serializer/JsonSerializationTest.php
index 44c22ff5f..7f59ca0d7 100644
--- a/tests/Serializer/JsonSerializationTest.php
+++ b/tests/Serializer/JsonSerializationTest.php
@@ -15,6 +15,7 @@
 use JMS\Serializer\SerializationContext;
 use JMS\Serializer\Tests\Fixtures\Author;
 use JMS\Serializer\Tests\Fixtures\AuthorList;
+use JMS\Serializer\Tests\Fixtures\DataFalse;
 use JMS\Serializer\Tests\Fixtures\DiscriminatedAuthor;
 use JMS\Serializer\Tests\Fixtures\DiscriminatedComment;
 use JMS\Serializer\Tests\Fixtures\FirstClassMapCollection;
@@ -151,6 +152,8 @@ protected static function getContent($key)
             $outputs['data_float'] = '{"data":1.236}';
             $outputs['data_bool'] = '{"data":false}';
             $outputs['data_string'] = '{"data":"foo"}';
+            $outputs['data_true'] = '{"data":true}';
+            $outputs['data_false'] = '{"data":false}';
             $outputs['data_author'] = '{"data":{"full_name":"foo"}}';
             $outputs['data_comment'] = '{"data":{"author":{"full_name":"foo"},"text":"bar"}}';
             $outputs['data_discriminated_author'] = '{"data":{"full_name":"foo","objectType":"author"}}';
@@ -480,6 +483,30 @@ public function testSerializingUnionProperties()
         self::assertEquals(static::getContent('data_string'), $serialized);
     }
 
+    public function testFalseDataType()
+    {
+        if (PHP_VERSION_ID < 80200) {
+            $this->markTestSkipped('False type requires PHP 8.2');
+            return;
+        }
+
+        self::assertEquals(
+            static::getContent('data_false'),
+            $this->serialize(new DataFalse(false)),
+        );
+
+        self::assertEquals(
+            new DataFalse(false),
+            $this->deserialize(static::getContent('data_false'), DataFalse::class),
+        );
+
+        //What should we expect here?
+        self::assertEquals(
+            null,
+            $this->deserialize(static::getContent('data_true'), DataFalse::class),
+        );
+    }
+
     public function testDeserializingComplexDiscriminatedUnionProperties()
     {
         if (PHP_VERSION_ID < 80000) {