Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.12.0 BC break on json column #1298

Closed
TakTaki opened this issue Mar 17, 2021 · 2 comments
Closed

3.12.0 BC break on json column #1298

TakTaki opened this issue Mar 17, 2021 · 2 comments

Comments

@TakTaki
Copy link

TakTaki commented Mar 17, 2021

Q A
Bug report? yes
Feature request? no
BC Break report? yes
RFC? no

Since 3.12.0, the serialization of json changed, introducing what I think is a BC break.
I have a Doctrine column define as follow
@ORM\Column(name="value", type="json", options={"jsonb"=true}, nullable=true)
Before 3.12.0, when the value stored was equals to true, the serialized value was true.
In 3.12.0 it now returns {true}.

I think this is link to recent changes here. I commented this line and got what I expected, ie true

Steps required to reproduce the problem

  1. @ORM\Column(name="value", type="json", options={"jsonb"=true}, nullable=true)

Expected Result

  • true

Actual Result

  • {true}
@TakTaki
Copy link
Author

TakTaki commented Mar 17, 2021

Just saw that I'm not alone and a PR is already pending #1295

@goetas
Copy link
Collaborator

goetas commented Mar 17, 2021

Done in #1295

@goetas goetas closed this as completed Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants