Update dependencies #250
Open
Update dependencies #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice thanks! It works on béluga? |
I will make sure of it, I'll update when I've tested it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The main objective of this PR is to remove the use of the branch "for_beluga_scilpy2" which uses a version of scilpy that can't be built properly. I just got another PR merged (scilus/scilpy#1048) into scilpy's master which fixes some issues regarding its problematic building process. Also, scilpy's master currently has the updated packages from the "for_beluga_scilpy2" branch.
With that fix, I also found that dwi_ml doesn't have a pyproject.toml which means that when building dwi_ml, the legacy building process invoking the
pythons setup.py developis called. Since that behavior will be enforced from pip 25.0 and onwards, we will need to make sure that dwi_ml follows that convention. I added that pyproject.toml with the minimal configuration needed for the project.If you prefer to wait for an official scilpy release in december, we want wait before merging this. But we could also just push another update whenever there's something released and more stable.