Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacement logic not implemented for param tables #105

Closed
SimonHeybrock opened this issue Jan 22, 2024 · 0 comments · Fixed by #106
Closed

Replacement logic not implemented for param tables #105

SimonHeybrock opened this issue Jan 22, 2024 · 0 comments · Fixed by #106
Assignees
Labels
bug Something isn't working

Comments

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Jan 22, 2024

#90 implemented replacing of params and providers (including with each other). However, this logic does not include param tables (and their columns). We still have check in place that prevent some (but not all) clashes (instead of replacing). Furthermore, we currently allow for indices and column labels that are duplicates of regular params or providers.

This needs to be thought through thoroughly, since there are some subtleties such as multi-level grouping operations where the index type of one table also is a column label of another table.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant