Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to prevent ~/.netrc modifications #49

Merged
merged 4 commits into from
Nov 3, 2023

Conversation

avalentino
Copy link
Contributor

  • userneme and password can always be provided explicitly file
  • none of the API functions attempts to modify the ~/.netrc file
  • ~/.netrc setup mover to the main function of the CLI

* userneme and password can always be provided explicitly file
* none of the API functions attempts to modify the ~/.netrc file
* ~/.netrc setup mover to the main function of the CLI
Copy link
Owner

@scottstanie scottstanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it'll work with these changes, and you're probably right with the sentiment of this PR that it's better not to surprise people by modifying the .netrc without notifying

eof/cli.py Outdated Show resolved Hide resolved
eof/cli.py Show resolved Hide resolved
eof/cli.py Show resolved Hide resolved
eof/cli.py Outdated Show resolved Hide resolved
eof/cli.py Outdated Show resolved Hide resolved
avalentino and others added 3 commits November 2, 2023 21:25
Co-authored-by: Scott Staniewicz <[email protected]>
Co-authored-by: Scott Staniewicz <[email protected]>
@scottstanie
Copy link
Owner

Oh should we also bump the version to 0.9.1?

@avalentino
Copy link
Contributor Author

Oh should we also bump the version to 0.9.1?

yes
Shall I do it in this PR?

@scottstanie scottstanie merged commit 6280704 into scottstanie:master Nov 3, 2023
7 checks passed
@avalentino avalentino deleted the feature/no-netrc-edit branch November 4, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants