Switch to codespaces and remove gitpod support #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The image got too large with the document compilation, so we remove it.
That it also supports systems without the service abstraction layer.
langchr86
requested changes
Feb 7, 2024
The tail -f /dev/null is needed for the java service, else the devcontainer/java stops and then the codespace creation fails.
Then the users only have to pull the image, and we test that the image can be built. The action build-images retrieves the build information from all docker-compose.yml files in the repo and builds the images in parallel. It also handles the correct tagging (commit hash, nightly on main, latest on tag, tag on tag) of the image. Adapted from: https://github.com/ase-23-the-bald-owls/swiss-card-exchange/blob/462c0b083dffad7e5275b7a8e4544406fc2527d5/.github/workflows/build-images.yml
BacLuc
force-pushed
the
switch-to-codespaces
branch
from
7852f2b to
9f09dae
Compare
langchr86
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.