Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up errors: use this_error in no_std or remove completely #317

Closed
haerdib opened this issue Nov 14, 2022 · 2 comments · Fixed by #419
Closed

Clean up errors: use this_error in no_std or remove completely #317

haerdib opened this issue Nov 14, 2022 · 2 comments · Fixed by #419
Assignees
@haerdib
Labels
F6-optimization This should optimize the performance

Comments

@haerdib
Copy link
Contributor

haerdib commented Nov 14, 2022

Tracking issue: dtolnay/thiserror#196
@haerdib haerdib added F7-enhancement Enhances an already existing functionality Q0-trivial Z2-blocked labels Nov 14, 2022
@haerdib
Copy link
Contributor Author

haerdib commented Dec 12, 2022

A new crate has been published: https://crates.io/crates/thiserror-core

@haerdib haerdib changed the title Use this_error in no_std as soon as available Use this_error in no_std as soon as available or remove completely Dec 20, 2022
@haerdib
Copy link
Contributor Author

haerdib commented Dec 20, 2022

Investigate if it should actually be used:

Just remember, if IoT should be one of the target deployments of this, we might want to get rid of thisError in no_std whatsoever, at least for production builds. The footprint of the error-chain that errors contain is not negligible.

#384 (review)

And if not, what else should be used, and maybe clean up completely.

@haerdib haerdib changed the title Use this_error in no_std as soon as available or remove completely Clean up errors: use this_error in no_std or remove completely Dec 20, 2022
@haerdib haerdib mentioned this issue Dec 20, 2022
Merged
@haerdib haerdib added F6-optimization This should optimize the performance and removed F7-enhancement Enhances an already existing functionality Q0-trivial labels Dec 23, 2022
@haerdib haerdib removed the Z2-blocked label Jan 4, 2023
@haerdib haerdib self-assigned this Jan 5, 2023
@haerdib haerdib mentioned this issue Jan 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haerdib haerdib

Labels
F6-optimization This should optimize the performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove thiserror scs/substrate-api-client
1 participant
@haerdib