Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch tests from SimpleStrategy to NetworkTopologyStrategy #217

Closed
dkropachev opened this issue Jul 14, 2024 · 0 comments · Fixed by #271
Closed

Switch tests from SimpleStrategy to NetworkTopologyStrategy #217

dkropachev opened this issue Jul 14, 2024 · 0 comments · Fixed by #271
Assignees
@sylwiaszunejko

Comments

@dkropachev
Copy link
Collaborator

dkropachev commented Jul 14, 2024 •
edited
Loading

SimpleStrategy is getting depricated, as replacement is it recomended to use NetworkTopologyStrategy instead.
In order to make test cases to reflect production use, let's switch tests to NetworkTopologyStrategy.
Tests that are specifically targeting SimpleStrategy stays as they are.
@dkropachev dkropachev mentioned this issue Jul 14, 2024
Merged
@sylwiaszunejko sylwiaszunejko mentioned this issue Sep 24, 2024
Merged
@sylwiaszunejko sylwiaszunejko self-assigned this Sep 24, 2024
sylwiaszunejko added a commit to sylwiaszunejko/gocql that referenced this issue Sep 25, 2024
@sylwiaszunejko
Switch tests from SimpleStrategy to NetworkTopologyStrategy
fbabd72 
SimpleStrategy is getting depricated, as replacement is it recomended to use NetworkTopologyStrategy instead.

This commit switches tests to use NetworkTopologyStrategy. Tests that are specifically targeting SimpleStrategy stays as they are.

Fixes: scylladb#217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sylwiaszunejko sylwiaszunejko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Switch tests from SimpleStrategy to NetworkTopologyStrategy sylwiaszunejko/gocql
2 participants
@dkropachev @sylwiaszunejko