Use ScyllaShardAwareDialer as a default dialer #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR scylladb#98 introduced a regression which changed default dialer to bare net.Dialer, instead of wrapped one with ScyllaShardAwareDialer. This resulted in dialer not being able to set local address which are required for correct shard assignment. Even though we have an integration test for that, test environment has only 2 shards, so it's possible that random port assignment passes it.
mmatczuk
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #98 introduced a regression which changed default dialer
to bare net.Dialer, instead of wrapped one with ScyllaShardAwareDialer.
This resulted in dialer not being able to set local address
which are required for correct shard assignment.
Even though we have an integration test for that, test environment
has only 2 shards, so it's possible that random port assignment passes it.