Make public interfaces implementable #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sylwiaszunejko
requested changes
Jun 3, 2024
host_source.go
Outdated
Comment on lines
438
to
441
| h.mu.Lock() | ||
| defer h.mu.Unlock() | ||
| addr, _ := h.connectAddressLocked() | ||
| return net.JoinHostPort(addr.String(), strconv.Itoa(h.port)) | ||
| h.mu.Lock() | ||
| defer h.mu.Unlock() | ||
| addr, _ := h.connectAddressLocked() | ||
| return net.JoinHostPort(addr.String(), strconv.Itoa(h.port)) |
There was a problem hiding this comment.
Not related to the PR
metadata_scylla.go
Outdated
| cache map[string]*KeyspaceMetadata | ||
| cache map[string]*KeyspaceMetadata |
There was a problem hiding this comment.
Not related to the PR
scylla.go
Outdated
|
|
scylla.go
Outdated
| return c.streams.NumStreams / 2 > c.AvailableStreams(); | ||
| return c.streams.NumStreams/2 > c.AvailableStreams() |
There was a problem hiding this comment.
Not related to the PR
session.go
Outdated
Comment on lines
2174
to
2177
| indexes []int | ||
| types []TypeInfo | ||
| keyspace string | ||
| table string | ||
| indexes []int | ||
| types []TypeInfo | ||
| keyspace string | ||
| table string |
dkropachev
force-pushed
the
fix-broken-public-interfaces
branch
2 times, most recently
from
140013b
to
30dc8d9
Compare
dkropachev
force-pushed
the
fix-broken-public-interfaces
branch
from
30dc8d9
to
5bdba32
Compare
sylwiaszunejko
approved these changes
Jun 3, 2024
dkropachev
force-pushed
the
fix-broken-public-interfaces
branch
3 times, most recently
from
bd80d3f
to
67c4a60
Compare
currently private interface `token` directly or indirectly present in lot's of interfaces and therefore makes them unimplementable: `SelectedHost`, `ExecutableQuery`, `HostSelectionPolicy`, `NextHost` To fix it we need to make all parts of interfaces be public
`ExecutableQuery` uses `partitioner` which makes it unimplementable
dkropachev
force-pushed
the
fix-broken-public-interfaces
branch
from
67c4a60
to
f0b3cef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently private interface
tokendirectly or indirectly present in lot's of interfaces and therefore makes them unimplementable:SelectedHost,ExecutableQuery,HostSelectionPolicy,NextHostTo fix it we need to make all parts of interfaces be public
Closes #183