Fix cowHostList can't have hosts with same ConnectAddress
#185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
cc58718
to
008c008
Compare
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
008c008
to
74e3404
Compare
sylwiaszunejko
requested changes
Jun 3, 2024
host_source.go
Outdated
| h.mu.Lock() | ||
| defer h.mu.Unlock() | ||
| addr, _ := h.connectAddressLocked() | ||
| return net.JoinHostPort(addr.String(), strconv.Itoa(h.port)) |
There was a problem hiding this comment.
These formatting changes are not related to this PR
There was a problem hiding this comment.
Sure, but it is definitely formatting issues, here, for example, it had spaces instead of tabs, is there a way to get these type of changes in ?
There was a problem hiding this comment.
Separate PR I guess
policies_test.go
Outdated
| "token 08 shuffling not configured": {hosts: []*HostInfo{ | ||
| {hostId: "0", connectAddress: net.IPv4(10, 0, 0, 1), tokens: []string{"00", "10", "20"}}, | ||
| {hostId: "1", connectAddress: net.IPv4(10, 0, 0, 3), tokens: []string{"25", "35", "45"}}, | ||
| {hostId: "2", connectAddress: net.IPv4(10, 0, 0, 2), tokens: []string{"00", "10", "20"}}, | ||
| {hostId: "3", connectAddress: net.IPv4(10, 0, 0, 4), tokens: []string{"25", "35", "45"}}, | ||
| {hostId: "4", connectAddress: net.IPv4(10, 0, 0, 3), tokens: []string{"50", "60", "70"}}, | ||
| {hostId: "5", connectAddress: net.IPv4(10, 0, 0, 4), tokens: []string{"50", "60", "70"}}, | ||
| }, routingKey: "8", lwt: true, shuffle: false, want: []string{"0", "2", "3", "1"}}, | ||
| }, routingKey: "8", lwt: true, shuffle: true, want: []string{"0", "2", "3", "4", "5", "1"}}, |
There was a problem hiding this comment.
Why are you changing shuffling in this example?
There was a problem hiding this comment.
my fault, changed it back
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
74e3404
to
90c76fd
Compare
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
90c76fd
to
4736a31
Compare
sylwiaszunejko
approved these changes
Jun 3, 2024
|
@sylwiaszunejko , I can't make pipeline to pass, starting container is failing, it has nothing to do with this PR |
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
4736a31
to
1cb65c3
Compare
|
@dkropachev please rebase to master and the pipeline should pass then |
cowHostList uses HostInfo.Equal to confirm host uniqueness, which relies on `ConnectAddress.Equal`, which does not allow to have different hosts with same `ConnectAddress`
dkropachev
force-pushed
the
fix-hostinto-uniqueness-logic
branch
from
1cb65c3
to
3642984
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue from gocql/gocql
Reopening of a #182
Problem
cowHostListusesHostInfo.Equalto confirm host uniqueness, which relies onConnectAddress.Equal.As result
cowHostListdoes not allow to have different hosts with sameConnectAddress.It breaks cases like accessing cluster via tcp or ssl proxy