Simplify tokenAwareHostPolicy.Pick #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What issues does it solve? A one-line description (at least) would be appreciated. |
Added |
dkropachev
force-pushed
the
dk/simlify-tokenaware-policy-pick
branch
from
598a4ae
to
ce30161
Compare
from tokenring? There is a missing information in the commit message and PR description |
Thanks, updated, from tablets |
Main goal is to make `tokenAwareHostPolicy.Pick` code less convoluted. But there are little functional changes: Before this PR hosts from tablets are not being shuffled There are three host information sources: tablets, meta and tokenring, Before this PR if tables returned no hosts for given token, in certain cases code did not consider meta or tokenring. And same for meta, it did not consider tokenring. After this PR, it starts goes through tablets, meta and tokenring, if current host sources yield no hosts it proceed to next one.
dkropachev
force-pushed
the
dk/simlify-tokenaware-policy-pick
branch
from
ce30161
to
b79ba6d
Compare
sylwiaszunejko
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main goal of this PR is to make
tokenAwareHostPolicy.Pickcode less convoluted.But there are little functional changes:
Start shuffling hosts obtained from tablets
Before this PR hosts from tablets are not being shuffled
Consider next hosts information source if current got 0 hosts
There are three host information sources: tablets, meta and tokenring,
Before this PR if tables returned no hosts for given token, in certain cases code did not consider meta or tokenring.
And same for meta, it did not consider tokenring.
After this PR, it starts goes through tablets, meta and tokenring, if current host sources yield no hosts it proceed to next one.
Removes unnecessary locks
There was locking done on
cowTabletListatt.tabletsto read tablets, but sincecowTabletListsolves parallel access issue through COW, it is not needed.