Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make get_prepared_metadata() public #1151

Open
lvboudre opened this issue Dec 13, 2024 · 2 comments
Open

Make get_prepared_metadata() public #1151

lvboudre opened this issue Dec 13, 2024 · 2 comments

Comments

@lvboudre
Copy link

I would like to pre serialized my rows and reuse the serialization result.
In order to do that I need to:

let my_row = (....)

let prepared_stmt = ...
let ctx = RowSerializationContext::from_prepared(ps.get_prepared_metadata()); /// ERROR: ge_prepared_metadata() is pub(crate) not pub.
let SerializedValues::from_serializable(ctx, my_row)

By making get_prepared_metadata this would make the API more coherent since
SerializedValues, RowSerializationContext are public so is their contructors metadata that ultimately rely on PreparedMetadata which is also public.

@Lorak-mmk
Copy link
Collaborator

We plan to address this use case by introducing BoundStatement: #941

SerializedValues is only present in the public API in some ClusterData method - we plan to change this so that users don't have to know about this type at all.

@wprzytula wprzytula added this to the 1.x.0 milestone Dec 15, 2024
@lvboudre
Copy link
Author

@Lorak-mmk

Would it be possible to make this function public in the next minor release?
I've read about #941 but the the PR is for release 1.x.x which is only 15% done and will probably exceed the release date of Feb 15th 2025.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants