Fix pendulum.test to properly unwind after an exception #445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if an exception occurred inside a 'with pendulum.test(...)' block, then the monkeypatch would remain in place instead of being un-done. This could cause confusing results, as one failing test could cause other tests to run with an unexpected mock in place and cause other failures.
njsmith
force-pushed
the
test-unwind-after-error
branch
from
2c11502 to
0b4f34e
Compare
|
All the test failures appear to be unrelated. |
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an exception occurred inside a 'with pendulum.test(...)'
block, then the monkeypatch would remain in place instead of being
un-done. This could cause confusing results, as one failing test could
cause other tests to run with an unexpected mock in place and cause
other failures.