Fix the typing annotation for the return of parse() #452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rodsenra
force-pushed
the
fix_parse_return_typing
branch
4 times, most recently
from
7ce2941 to
7368f1e
Compare
rodsenra
force-pushed
the
fix_parse_return_typing
branch
from
7368f1e to
13654e1
Compare
|
@sdispater this looks good |
traviscook21
reviewed
Jun 5, 2020
| def parse(text, **options): # type: (str, **typing.Any) -> str | ||
| def parse( | ||
| text, **options | ||
| ): # type: (str, **typing.Any) -> typing.Union[Date, Time, Duration] |
|
I have code like this all of over some repos I'm working on I wish it could be as simple as Anything I can do to help get this merged / released? |
|
Thanks for your contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically a bug fix PR based on discussion for Issue #450
This PR incorporates a suggestion from @shot in
https://github.com/sdispater/pendulum/pull/320/files#diff-d79c6f58aeecd540ddd61603df9184aaR17