Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix now() behavior for DST #483

Merged
merged 2 commits into from
Jul 13, 2020
Merged

Fix now() behavior for DST #483

merged 2 commits into from
Jul 13, 2020

Conversation

sdispater
Copy link
Collaborator

As reported in #417, now() could return the wrong result on DST transitions.

now() used instance() but it's actually not necessary and we can return DateTime instance directly which fixes the issue.

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater mentioned this pull request Jul 12, 2020
Closed
@sdispater sdispater merged commit 8af1e2e into master Jul 13, 2020
@sdispater sdispater deleted the fix-now-on-dst branch July 13, 2020 10:30
@sdispater sdispater mentioned this pull request Jul 13, 2020
Merged
@tomage tomage mentioned this pull request Jul 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sdispater