Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors where hours and days were not handled correctly when adding durations #775

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

sdispater
Copy link
Collaborator

Fixes #768

Pull Request Check List

  • Added tests for changed code.
  • Updated documentation for changed code.

@sdispater sdispater added the bug label Dec 15, 2023
Copy link

codspeed-hq bot commented Dec 15, 2023

CodSpeed Performance Report

Merging #775 will degrade performances by 19.39%

Comparing fix/add-duration-days-hours (12d5f09) with master (1ff9a1c)

Summary

❌ 1 regressions
✅ 1 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark master fix/add-duration-days-hours Change
test_format 2.3 ms 2.8 ms -19.39%

@sdispater sdispater force-pushed the fix/add-duration-days-hours branch from eaa3148 to 12d5f09 Compare December 15, 2023 00:09
@sdispater sdispater merged commit 78fdc33 into master Dec 15, 2023
17 of 18 checks passed
@sdispater sdispater deleted the fix/add-duration-days-hours branch December 15, 2023 00:14
@sdispater sdispater mentioned this pull request Dec 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase DateTime by 1 day across daylight saving change point fails
1 participant