Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

modified_files and modified_lines_in_file on CommitMsg #726

Closed
Quintasan opened this issue Sep 14, 2020 · 2 comments · Fixed by #727
Closed

modified_files and modified_lines_in_file on CommitMsg #726

Quintasan opened this issue Sep 14, 2020 · 2 comments · Fixed by #727
Labels
enhancement

Comments

@Quintasan
Copy link
Contributor

Quintasan commented Sep 14, 2020 •
edited
Loading

I want to create a hook that makes sure that the commit has a longer body describing the changes in detail but only when more than 30 lines are changed across 3 or more files.

Would it be possible for modified_files to work the same way as it does in PreCommit hook?

EDIT: I think I would need modified_lines_in_file as well for this.
@Quintasan Quintasan changed the title modified_files on CommitMsg modified_files and modified_lines_in_file on CommitMsg Sep 14, 2020
@sds
Copy link
Owner

sds commented Sep 15, 2020

Happy to merge a pull request adding this functionality!

@Quintasan
Copy link
Contributor Author

Well, I'll try my hand but expect nothing of value 😅

@Quintasan Quintasan mentioned this issue Sep 18, 2020
Merged
@sds sds closed this as completed in #727 Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modified_files and modified_lines_in_file on CommitMsg
2 participants
@sds @Quintasan