Fix unlinkat error in make tools and bind mount cleanup #270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modules installed using go in /tmp had elevated privileges, causing unlinkat errors when deleting them. Changed permissions before removal to avoid errors and ensure make tools runs smoothly.
**Error Reason**: Elevated privileges on bind mounts caused unlinkat errors during deletion. **Fixes**: 1. Explicitly create bind mounts to avoid elevated privileges. 2. During container deletion, first remove all contents inside the working directory, then kill the container. 3. In DiskCleanup, perform ContainerCleanup before StorageCleanup.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request addresses the
unlinkaterror encountered while runningmake toolsand duringbind mountcleanup.Details
unlinkaterrors during deletion.Testing
make toolsruns successfully without errors.