Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pip check worflow #124

Closed
pvk-developer opened this issue Nov 2, 2021 · 0 comments · Fixed by #129
Closed

Add pip check worflow #124

pvk-developer opened this issue Nov 2, 2021 · 0 comments · Fixed by #129
Assignees
Labels
internal The issue doesn't change the API or functionality
Milestone

Comments

@pvk-developer
Copy link
Member

The current CI workflows and local test and lint commands do not catch dependency incompatibilities.

For example, installing the repository for development on the v0.6.0-dev branch results in these errors:

ERROR: numba 0.54.1 has requirement numpy<1.21,>=1.17, but you'll have numpy 1.21.3 which is incompatible.
ERROR: sdmetrics 0.3.2 has requirement rdt<0.6,>=0.5.0, but you'll have rdt 0.6.0 which is incompatible.
ERROR: deepecho 0.2.1 has requirement torch<1.8,>=1.4, but you'll have torch 1.10.0 which is incompatible.
ERROR: ctgan 0.4.3 has requirement rdt<0.6,>=0.5.0, but you'll have rdt 0.6.0 which is incompatible.
ERROR: sdv 0.12.1 has requirement rdt<0.6,>=0.5.3, but you'll have rdt 0.6.0 which is incompatible.
ERROR: autopep8 1.6.0 has requirement pycodestyle>=2.8.0, but you'll have pycodestyle 2.7.0 which is incompatible.

A pip check command should be made part of the local and CI tests to make sure that our dependency tree is always clean.

@pvk-developer pvk-developer self-assigned this Nov 2, 2021
@pvk-developer pvk-developer added the internal The issue doesn't change the API or functionality label Nov 2, 2021
@katxiao katxiao added this to the 0.5.0 milestone Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal The issue doesn't change the API or functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants